Merge remote-tracking branch 'upstream/master' into dev

Jenkinsfile

@@ -85,7 +85,7 @@ pipeline {
                 sshagent(["${params.GIT_CREDENTIAL_ID}"]) {
                   nodejs(nodeJSInstallationName: "${params.NODEJS_INSTALLATION}") {
                     withCredentials([
-                        file(credentialsId: params.ANDROID_API_KEY_CREDENTIAL, variable: 'GOOGLE_APPLICATION_CREDENTIALS')
+                        string(credentialsId: params.ANDROID_API_KEY_CREDENTIAL, variable: 'GOOGLE_APPLICATION_CREDENTIALS')
                     ]) {
                         sh './tools/jenkins-publish-android.sh'
                     }

README.md

@@ -3,21 +3,23 @@
 An embedded webview
 
 Build-time env config:
-APP_TITLE=The app title which does not appear used much
-APP_URI=THe uri to load
-APP_COLOR=The color to use a theme that does not appear used much
-
+APP_TITLE=The app title which does not appear used much APP_URI=THe uri to load APP_COLOR=The color to use a theme that does not appear used
+much
 
 Pass them to dart usign --dart-define:
 `--dart-define="APP_TITLE=test" --dart-define="APP_URI=https://www.charlyghislain.com"`
 
 Pass those flags to flutter run, ...
 
+See jenkinsfile.
+
 ## To publish on app store
 
-- Clone this repo
+- Fork this repo
 - Alter the android and ios config to your liking, package name, key etc
-- Publish
+- Push your branding changes to another repo
+- Set up the jenkins job
+- Merge upstream changes regularly
 
 
 ## Adnroid checklist:
@@ -35,5 +37,4 @@ A few resources to get you started if this is your first Flutter project:
 - [Cookbook: Useful Flutter samples](https://flutter.dev/docs/cookbook)
 
 For help getting started with Flutter, view our
-[online documentation](https://flutter.dev/docs), which offers tutorials,
-samples, guidance on mobile development, and a full API reference.
+[online documentation](https://flutter.dev/docs), which offers tutorials, samples, guidance on mobile development, and a full API reference.